Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

No bug: Add missing localization for test networks copy #7647

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

StephenHeaps
Copy link
Contributor

Summary of Changes

  • Missed localization when moving test networks to their own section

This pull request fixes #

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@StephenHeaps StephenHeaps added this to the 1.53 milestone Jun 27, 2023
@StephenHeaps StephenHeaps requested a review from a team as a code owner June 27, 2023 15:36
@StephenHeaps StephenHeaps self-assigned this Jun 27, 2023
@StephenHeaps StephenHeaps enabled auto-merge (squash) June 27, 2023 15:37
@StephenHeaps StephenHeaps merged commit 78cecc5 into development Jun 27, 2023
@StephenHeaps StephenHeaps deleted the wallet/network-selection-copy branch June 27, 2023 15:58
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants